Encoder-decoder task support #16
Conversation
|
I have addressed the security issue and rebased this branch. I now mark it as ready for review, as we may come up with unit tests during the review process. |
top-sekret
changed the title
|
Also note that this pull request can be merged before the OIOIOI one, because it does not alter any visible behavior. The converse is of course not true. |
sio/executors/encdec_common.py
Outdated
| from sio.workers.util import decode_fields, replace_invalid_UTF, tempcwd, TemporaryCwd | ||
| from sio.workers.file_runners import get_file_runner | ||
|
|
||
| import six |
There was a problem hiding this comment.
is this needed? we don't support python 2.x anymore.
There was a problem hiding this comment.
This is most probably unneeded and is an artifact of trying to merge these changes with an older Python 2 codebase, used in Szkopuł. I am for removing this.
|
I really wish this could be made to work. However, I am being stopped by what I think is a sio2jail bug. |
|
I think it's because Github runners don't give access to perf counters. But recently we created our own runner that can use sio2jail. |
I mean they won't even run locally. |
| @@ -28,13 +28,13 @@ def _make_cmdline(self, executor): | |||
| class CCompiler(CStyleCompiler): | |||
| compiler = 'gcc' | |||
| # Without -static as there is no static compilation on Mac | |||
There was a problem hiding this comment.
I'm not sure whether this comment even has sense.
I would guess that the docker images on macOS don't have the static linking issues like the base OS.
There was a problem hiding this comment.
I would guess that we don't care about crap macOS in workers.
|
Okay, I'm out of patience. The tests do work. However, the CI is absolute crap and can't even set up Python. I am reverting (actually rebasing out to get rid of the mess) all CI related commits. I will be running the tests on |
This is a draft pull request that adds support for encoder-decoder tasks, as seen at latest OI finals.
Notes:
Also see sio2project/oioioi#191.